RealFuel not working with tanks from making history dlc.

Question

RealFuel not working with tanks from making history dlc.

aishwarya25252 opened this issue 9 months ago · 6 comments

Tanks like FL-TX1800 FL-TX900 has no tank options when using RO , it has all options when using Real Fuel with stock like config without RO . MK2 pod from the same DLC has RealFuel tank options. Is it a bug or expected ? Because these tanks don't show as WIP or non RO .

Answer 1 · 2023-10-20T21:16:41.000Z

We probably should make all the DLC parts WIP, but then again there's a ton of older parts that have questionable configs too.

Answer 2 · 2023-10-21T09:36:58.000Z

Could you point me to the documentation for this codebase I'll try and fix this bug myself If that's alright you can assign me to this issu ?

Answer 3 · 2023-10-22T21:58:34.000Z

Thanks! The pins (and the people) in #moddev-help in the RO discord are probably the best reference. There's also some articles on the wiki under the Contributing section.

Answer 4 · 2023-10-23T12:12:14.000Z

I have found the place and added the configs seems real fuel doesn't have configs for volume of the fuel tanks found in this DLC , RO has the required configs to support these tanks so they so up without any option for fuels . I have added the config with calculated volume and have tested it works now . Made a pr in the real fuels repo . KSP-RO/RealFuels#330 , merging it would solve this issue .

Answer 5 · 2023-10-23T12:12:43.000Z

@NathanKell thanks for the support .

Answer 6 · 2023-10-25T05:23:46.000Z

Thanks for making the PR! :)