KablamoOSS/kombustion

Kombustion can not deploy tags to ECS task definition

apainemilla opened this issue · 0 comments

Tagging for ECS was added
https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/ReleaseHistory.html

Describe the bug
When creating a CF stack into cloud formation you can not create any tags on ECS services. When you apply an upsert you get a error "Encountered unsupported property Tags"

Script settings

    TaskDefinition:
        Type: AWS::ECS::TaskDefinition        
        Properties:
            Family: !Sub ${Namespace}-Datadog-Agent-${Environment}
            NetworkMode: host
            TaskRoleArn: !GetAtt TaskRole.Arn
            ContainerDefinitions:
              - Name: !Sub ${Namespace}-Datadog-Agent-${Environment}
                Essential: true
                Image: datadog/agent:6.11.3
                Memory: 256
                Cpu: 10
                LogConfiguration:
                  LogDriver: awslogs
                  Options:
                      awslogs-group: !Ref AWS::StackName
                      awslogs-region: !Ref AWS::Region
                Tags:
                  - Key: "Name"
                    Value: !Ref "DataDog-Agent-${Namespace}-${Enviroment}"
                  - Key: "env_type"
                    Value: !Ref "${Namespace}"
                  - Key: "env_group"
                    Value: !Ref "${EnvironmentType}"
                  - Key: "cluster_type"
                    Value: !Ref "${ClusterType}"
                PortMappings:

If I drop the keys part and then I am able to upsert this into kombustion.