[BUG] Invalid use of "referrer" attribute
Closed this issue · 1 comments
Detailed description
A few locations within Sage (listed below) include referrer="no-referrer" within links, neither of which is valid. rel="noreferrer" appears to be the intended output here.
However, judging by the use cases here and in kajabi-products, rel="noopener" would seem to be more relevant throughout help links with target="_blank", as this still allows referral tracking to take place while keeping the security benefits. Per CX, the link references are helpful for customer support and are tracked in Google Analytics.
Impacted files:
docs/lib/sage_rails/app/views/sage_components/_sage_page_heading.html.erbpackages/sage-react/lib/HelpLink/HelpLink.story.jsxpackages/sage-react/lib/PageHeading/PageHeading.story.jsxpackages/sage-react/lib/Type/Type.story.jsx
Contacted a member of CX Ops to get further details on what their help link tracking looks like. Once we have more details, we may want to follow up with a change throughout the app, swapping noreferrer with noopener.