Make rml_rtmp::handshake::HandshakeError public
Closed this issue · 2 comments
Hi!
First, thanks for a great library - really enjoying working with it so far. I am fairly new to Rust and am currently building an rtmp server with tokio (using the mio example as a base).
Currently HandshakeError is only publicly availble through rml_rtmp::handshake::errors but is privately imported in rml_rtmp::handshake.
When working on the handshake phase of the connection, I imported all the components I required via rml_rtmp::handshake::{HandshakeResult, Handshake, PeerType}, but had to have a separate import to get access to the HandshakeError.
I suggest for simplicity publicly exposing HandshakeError through rml_rtmp::handshake.
Good catch, it should definitely be in importable via rml_rtmp::handshake::HandshakeError;! I can fix this later today :)
Don't hesitate to point out any oddities that come from implementing it with Tokio. I wanted to do a Tokio implementation but didn't want the overhead of learning Rust + RTMP + tokio all at the same time :)