KamandPrompt/baat-cheet

Refactor

Closed this issue · 12 comments

At present there is some unnecessary code in each file. You are supposed to remove that unnecessary code.

Tasks:

  • Remove unnecessary code(of JS as well as CSS).

  • Wherever possible replace code like

anotherElement.innerHTML = '<element id="someID" class="someClass">Some text</element>';

with code like

element = document.createElement("element");
element.classList.add("someClass");
element.id = "someID";
element.innerText = "Some Text";
anotherElement.innerHTML = element;

Most important thing is to create separate commit for each file.

I would like to Contribute onto this project .. Feel free to assign me this task.

Go ahead @bineetNaidu, I assigned this to you.

kpbot commented

Hello @DEEPA-CHERI, you have been unassigned from this issue because you have not updated this issue or any referenced pull requests for over 7 days.

You can reclaim this issue or claim any other issue by commenting @kpbot claim on that issue.

Thanks for your contributions, and hope to see you again soon!

Hello @bineetNaidu, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 4 days. Are you still working on this issue?

If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 3 days.

If you've decided to work on something else, simply comment @kpbot abandon so that someone else can claim it and continue from where you left off.

@kpbot abandon

Some changes have been done by @bineetNaidu, Now this issue is open for further changes.

kpbot commented

Welcome to KamandPrompt, @DEEPA-CHERI! We just sent you an invite to collaborate on this repository at https://github.com/KamandPrompt/baat-cheet/invitations. Please accept this invite in order to claim this issue and begin a fun, rewarding experience contributing to KamandPrompt!

Here's some tips to get you off to a good start:

See you on the other side (that is, the pull request side)!

Hi, it seems permission to push is denied for me.

Yeah, in order to contribute you are supposed to make a pull request.

Hi, In order to raise pull request need to push the code into the branch right?

Yeah and read our contributing guidelines.

Duplicate at #159.