Allow stacking data sets in Line Chart

Question

Allow stacking data sets in Line Chart

KarthikRIyer opened this issue 5 years ago · 28 comments

A stack plot is similar to a Line Plot, the difference being that the data sets are stacked over one another. A simple example can be found here.

This task will require you to implement the following:

Add functions to atleast two from the three renderers (AGG/SVG/CoreGraphics) to allow drawing of solid polygons.
Add the capability to allow stacking of data sets in Line Chart.

boronhub commented 5 years ago

colab

Answer 1 · 2019-12-10T15:28:51.000Z

Hi, I'm interested in working on this.

Answer 2 · 2019-12-10T15:32:27.000Z

@boronhub that's great! You should claim the task on the GCI website and also state there that you're interested in working on this issue. If you have any other questions, feel free to ask.

Answer 3 · 2019-12-10T15:34:19.000Z

One of my other tasks still hasn't been reviewed, so I can't claim it yet. Can I still start work on this so as to familiarize myself with SwiftPlot ?

Answer 4 · 2019-12-10T15:35:34.000Z

@boronhub sure!

Answer 5 · 2019-12-10T15:38:46.000Z

Is there a Google Group or an IRC where we can discuss this ?

Answer 6 · 2019-12-10T15:40:24.000Z

There is a Google Group for Swift for TensorFlow, but I prefer we discuss it here in GitHub issues.

Answer 7 · 2019-12-10T15:46:53.000Z

The changes have to be made in LineChart.swift, right ?

Answer 8 · 2019-12-10T16:48:59.000Z

@boronhub yes. You need to make changes in LineChart.swift.
You can create a file LineChartSeriesOptions.swift similar to HistogramSeriesOptions.swift. Using that you can decide if you want the plot to be stacked or not.

Answer 9 · 2019-12-10T17:02:05.000Z

@karwa do you have any suggestions regarding this?

Answer 10 · 2019-12-10T18:25:27.000Z

Not particularly - just to follow the example set by BarGraph when it comes to stacking.

Matplotlib calls this a stackplot and has this as a separate kind of chart. I think that would probably also make sense for us, rather than combining it with the line chart (for example, you can't have multiple series on a line chart if the some of the series also have stacks and are filled underneath).

Answer 11 · 2019-12-10T18:30:23.000Z

I agree. @boronhub you could make a new chart type. I think you should be able to lift most of the code from line chart and make the required changes to get it working.

Answer 12 · 2019-12-11T06:49:26.000Z

The example notebook isn't working in Jupyter.
It's saying Line magic command '%install' not found.

Answer 13 · 2019-12-11T08:42:09.000Z

@boronhub the example notebook isn't updated. Are you using swift-jupyter, or colab?

Answer 14 · 2019-12-11T12:24:38.000Z

Plotting on colab won't work at the moment. There's some problem in that. But you can use swift-jupyter. The notebook example hasn't been updated. You can copy the code from the example in the docs.

Answer 15 · 2019-12-15T02:08:52.000Z

@boronhub are you still working on this? I got swiftplot on Linux working if using the notebook is giving you difficulty.

Answer 16 · 2019-12-15T06:49:53.000Z

My VM keeps crashing so im trying to build swift on Windows. I got the notebook working, but %install still isn't working.

Answer 17 · 2019-12-15T08:46:32.000Z

@boronhub you can try using the Linux Subsystem for Windows. So you won't need a VM to use Linux. Check this out: https://docs.microsoft.com/en-us/windows/wsl/install-win10

But you won't be able to use swift-jupyter or any GUI based applications, but you'll be able to work on SwiftPlot and won't need to build swift.

Answer 18 · 2019-12-15T11:05:01.000Z

Yeah , I tried WSL as well but to no avail.

Answer 19 · 2019-12-15T11:05:16.000Z

I'll figure it out soon

Answer 20 · 2019-12-15T23:14:16.000Z

Alright, best of luck!

Answer 21 · 2019-12-17T14:24:34.000Z

error: could not build C module 'CoreFoundation'

can't seem to get over this, any suggestions ?

Answer 22 · 2019-12-17T16:19:43.000Z

@boronhub where are you getting this error? Could you provide more details?

Answer 23 · 2019-12-17T19:00:53.000Z

upon executing

%install-swiftpm-flags -Xcc -isystem/usr/include/freetype2 -Xswiftc -lfreetype
%install '.package(url: "https://github.com/IBM-Swift/BlueCryptor.git", from: "1.0.28")' Cryptor
%install '.package(url: "https://github.com/KarthikRIyer/swiftplot", .branch("master"))' SwiftPlot AGGRenderer

in a jupyter notebook (used WSL)

Answer 24 · 2019-12-17T19:08:38.000Z

@boronhub I haven't seen this error before and am having trouble using jupyter notebook in WSL. But you do not need jupyter to work on swiftplot. You can still use the command line.

Answer 25 · 2019-12-17T19:32:02.000Z

Is there any documentation for this?

Answer 26 · 2019-12-17T19:42:54.000Z

Try installing swift on ubuntu linux here: https://itsfoss.com/use-swift-linux (use the most recent swift version files)

Answer 27 · 2019-12-20T00:19:12.000Z

@boronhub - Looks like you are opening in python notebook, %install etc. will not work in Jupyter. I tried installing packages through Anaconda and Python and was not successful.

Alternatively, you can use the route mentioned by @WilliamHYZhang ...It is working!

Also, I tried using Docker image https://github.com/apple/swift-docker. It works as well, but requires some minor tweaks.