Changing settings in reactmap duplicates entry
Opened this issue · 4 comments
This is what I have:
When I edit this tracking and remove cap by example, entry doesn't get modified but duplicates original one with changes:
I tried that with single mons and looks like this issue also affects them. Issue doesn't only affect cap, rank also and proly more.
This issue affects reactmap only. Poracleweb is fine. TurtleSocks claims it's not rm issue: WatWowMap/ReactMap#399 (comment)
"claims" I think you are misunderstanding the fundamental differences between ReactMap and PoracleWeb.
PoracleWeb interacts directly with the Poracle db, it grabs some basic config settings from Poracle but otherwise it has all of the logic to run independently.
ReactMap simply sends JSON payloads to Poracle's API endpoints for processing, then Poracle handles the db connection. It has relatively little logic, it's just a UI layer for interacting with Poracle, not Poracle's db.
When a user selects edit are you presenting as a new row, or using the edit row functionality on the monster api? @TurtIeSocks
@kamieniarz a reproduction api call sequence would help
@jfberry here is how it goes:
- Open poracle menu in reactmap
- Open mons tab
- Select 'edit' option for existing entry
- Edit settings
- Save
- Entry that was edited is still there and new one was created with values that match changes that were made
@TurtIeSocks no idea how these things work. That's why I said it works fine in poracleweb but the issue is with reactmap. If that's irrelevant then simply ignore my finding
I don't have up to date reactmap so unable to repro so need api calls