Keep-Current/web-miner

Add pre-push hooks

Createdd opened this issue 6 years ago · 2 comments

Createdd commented 6 years ago

Add pre-push hook to check for:

linting
formatting
tests

Yes, this is done in Travis, but it's good to have immediate feedback before pushing bad code

Createdd commented 6 years ago

Good article here: https://ljvmiranda921.github.io/notebook/2018/06/21/precommits-using-black-and-flake8/

Createdd commented 6 years ago

Pushed a branch with the config: https://github.com/Keep-Current/web-miner/blob/feature/21_Add_pre_push_hooks/.pre-commit-config.yaml
But it's not working. Not quite sure why.

If someone else has done something similar feel free to take on that issue