KenEucker/biketag-vue

[BUG] when a BikeTag Ambassador approves a new BikeTag Post, the remaining tags in the queue are not cleared

Closed this issue · 1 comments

Describe the bug
When the autopost function runs and creates a new BikeTag Post by calling setNewBikeTagPost, the remaining tags in the queue are added to the BikeDex and the queue is cleared. See:

if (remainingNonWinningTags.length) {

But when the approve function calls setNewBikeTagPost, this additional step is not performed. It should be. See:

const newBikeTagPostedResults = await setNewBikeTagPost(approvedTag, game, currentBikeTag)

To Reproduce
Steps to reproduce the behavior:

  1. Create a new BikeTag Post
  2. Create another BikeTag Post
  3. Approve one tag for the winner of the round as a BikeTag Ambassador
  4. See that the queue is not cleared, nor are images saved in the BikeDex

Expected behavior
The queue should be cleared and images copied over to that game's BikeDex.

I believe that this is working now, with the recent overhauling of how new tags are posted.