KevinJump/uSync-Legacy

U7 & U8: Sort, Rename, Move causes usync to not apply changes

Opened this issue · 6 comments

JohnBergman commented

If you have a node with a series of nodes, and one of the nodes has children.

Sort the top level node, move some around.
Rename one of the nodes
Move it to a child of the child node that has children

I also noticed that usync appears to have issues whenever you sort the content; were the sort order does not appear to be updated (I see the content nodes listed as changed).

JohnBergman commented

I can reproduce this 100% of the time in my umbraco 7.14.0 instance.

Take a backup of the source database and use it for the target so at that point they are 100% the same.

Take a node with children, move it to a parent in another tree (I have the settings to export, but not import).

Copy the usync folder over, and import... the parent/doc node error always happens

JohnBergman commented

Same as issue 213

KevinJump commented

Hi
just focusing on the error for the moment (will look at sort to in a bit)

Having trouble reproducing this - uSync (4.0.14) Content (4.1.8) Umbraco (7.15.2)

I have done the following

  1. Build Two new sites with Standard starter kit.
  2. Made sure they share a machine key
  3. Copied database from Source to target so they are the same.
  4. On Source Created new Content Page - 'NewPage'
  5. Copied over uSync folder to target site imported just to make sure we are only dealing with only move issues (and not the order of creation*)
  6. On Source Moved the About us page (and therefore it's child pages) under new page
    --
    and this is where you might get an issue, but both ways I don't get an error

7.1
a) replace the uSync folder in target with the source - that is delete the folder and copy over (see below)
b) run import,
c) About us pages are under 'NewPage'

7.2
a) Copy the uSync folder from source to target
b) run import (it reports the same things twice)
c) the about pages may or may not be under a new page - but there is no error

The replace is the way to do it because a copy won't remove the old .config files on target for the previous location of the page, that's why I tried both ways, but neither is throwing the error for me :(

I am going to try on Umbraco 7.14.0 too, to see if its anything, but I am not aware of any changes there that are likely to have altered this.

*Order of creation issue - I think you can get an issue if the node you move to doesn't exist yet, and the other nodes do, but that is something I need to confirm, I am just trying to reduce the variables for this test.

KevinJump commented

OK, I can only reproduce if the node you are moving the content to is also new to the target site, and then it is a one time issue (if you run the import again it works)

just want to confirm that is what you are seeing ?

My steps are:

  1. Create a new node ('MyPage')
  2. Move a tree of nodes from somewhere else to under 'MyPage'
  3. Replace uSync folder on target from source
  4. run import - get node@ error.
  5. run import again, no error, everything in right place .

there will be a creation order issue here, but probibly at the publish point, because even on the first run the nodes do get created and moved, just not published, a second import publishes them. If this is the same i can concentrate on that element and workout what might need to happen when.

JohnBergman commented

I see that, and it eventually resolves itself most of the time.

Is it possible to have the UI update / continue to update / show the correct state when that error happens? Once you get the error, it looks like it just keeps going, but you cannot tell what it is doing.

I am also wondering if on import/export you could determine the total number of nodes and maybe display a counter... I just ran an export that ran for like 2 hours; I could see it working in the log so that was fine this time, but when it is long running it makes me feel like there is an issue. showing more than the 3 dots would go along way towards easing anxst :-)

JohnBergman commented

I have also seen it when adding a new node and sorting after adding; then copying the usync over and importing. I havent been doing that for a while so I dont recall the exact scenario - I was looking through my notes to see if I could find more info without luck