Translations into Ukrainian language
MarekPatyna opened this issue · 8 comments
material-react-table version
v2.11.2
react & react-dom versions
v18.2.0
Describe the bug and the steps to reproduce it
Hi
I am working on a project where I am using material react table. I need the table to also support Ukrainian language. I created a translation that fully supports Ukrainian language. I would be grateful for adding this to MRT.
Greetings
Minimal, Reproducible Example - (Optional, but Recommended)
https://codesandbox.io/p/sandbox/mrt-ua-i18n-language-v6tgp9?file=%2Fua%2Findex.esm.d.ts
Screenshots or Videos (Optional)
Do you intend to try to help solve this bug with your own PR?
No, because I do not know how
Terms
- I understand that if my bug cannot be reliably reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
Yeah for sure, just make a PR in the same format as the current uk locale`.
https://github.com/KevinVandy/material-react-table/blob/v2/packages/material-react-table/src/locales/uk.ts
btw, what's the difference between uk and ua?
Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.
https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA
@MarekPatyna It seems that the full locale name is ukUA from my understanding. That's what Material UI itself names their locale. And usually its fine to just refer to it by the first 2 letters, unless there are multiple dialects.
I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/
@MarekPatyna Your translations seem to be a lot different than the current uk locale in MRT. Which one is more correct? The existing one or yours?
I don't speak Ukrainian at b2/c1+ level, so I would personally suggest leaving the current translation. Thanks for the quick replies and good luck with MRT development!
I always refer to this website when checking: https://saimana.com/list-of-country-locale-code/
And if a language isn't there, its more comprehensive source is https://iso639-3.sil.org/code_tables/639/data.
Thank you for your reply. Unfortunately but I did not see that Ukrainian was created because I was sure that "uk" corresponds to United Kingdom. In my opinion and from what I checked on the internet the ISO abbreviation for Ukrainian is UA or possibly UKR but not UK.
https://www.andiamo.co.uk/resources/iso-language-codes/
https://laendercode.net/en/country/ua
https://www.iso.org/obp/ui/#iso:code:3166:UA
https://en.wikipedia.org/wiki/ISO_3166-2:UA
@MarekPatyna To clarify, the ISO 3166-2 code you were seeing for Ukraine (UA) is the country code, not the language code: https://en.wikipedia.org/wiki/ISO_3166#Parts
Apologies for writing back so late but I completely forgot about this issue. Thank you again @imnasnainaec @KevinVandy for your help.
Best regards!