Kharacternyk/pacwall

DE integration.

Kharacternyk opened this issue · 10 comments

Kharacternyk commented

We put the generated wallpaper in ~/.local/share/wallpapers, but, if the DE isn't GNOME, the wallpapers there are unresized. If the DE doesn't provide an option to center the image and use a solid color outside, setting the wallpaper from GUI is broken.

Possibilities:

  • Strictly require imagemagick.
  • Check whether imagemagick is installed and resize the image if it is.
  • Provide support for DEs separately. As of now large effort has been put only in GNOME support.
  • Pretend there is no problem.
Kharacternyk commented

Related: #14.

p00f commented

Since the script is pacWALL and not pacIMAGE, we can strictly require imagemagick
(installed size 9.7 MB)
image

p00f commented

Also for many users, imagemagick is already installed as a dependency of something else anyway

Kharacternyk commented

I don't like imagemagick as a mandatory dependency because I don't need it. If one doesn't use a DE, one shouldn't be told to install imagemagick.

p00f commented

Make 2 branches - DE and WM? You can make 2 scripts in the same branch but 2 branches will be easier for packaging

Kharacternyk commented

The difference would be just that in one version we check for GNOME to resize and in other we don't. Maybe a command line flag like -D to force resizing will do fine?

p00f commented

You need imagemagick for all DEs. But yeah, good idea

p00f commented

There is no point in copying unresized images to XDGOUT because they are meant to be used through the GUI

Kharacternyk commented

Then maybe copying to XDGOUT should be a part of "DE mode" that is activated via -D.

  • 👍1
Kharacternyk commented

I guess b93a4e2 closes this.