Use unsigned types where possible
Closed this issue · 7 comments
Use of unsigned types slightly improves the performance. Early tests show that the compiled binary remains the same with the only difference being instructions like shr_s, gt_s, etc being replaced with their unsigned counterparts. However, some code paths are faster with signed types, so further evaluation is required.
I could help with this, but without tests it will be very difficult for me. It would be great to add tests either from the javascript side or directly to AssemblyScript via as-pect
I can help with tests, if @lexaknyazev is OK with this. 🙂 My usual choice is tape; it's clean and simple compared to most JS/TS test libraries. But I'm certainly open to other ideas. Opened a PR at #8.
I totally fine with tape. Btw did you see ava? Also pretty great fully async test framework
ava looks totally reasonable, too! I just haven't used it before. 🤷♂️
Let me know when all tests are ready)
@MaxGraey
The CI is ready, should be enough to ensure correctness. We'll probably add some benchmarks later.
Great!