Missing `SPIRVSubTarget.h` file

Question

Missing `SPIRVSubTarget.h` file

Closed this issue 9 years ago · 4 comments

While trying to compile the new spirv-target branch, I get the following error:

In file included from ../lib/Target/SPIRV/SPIRVISelDAGToDAG.cpp:44:
../lib/Target/SPIRV/SPIRVTargetMachine.h:41:10: fatal error: 'SPIRVSubTarget.h' file not found
#include "SPIRVSubTarget.h"

@yxsamliu Did you forget to push this file? :-)

Answer 1 · 2015-12-08T03:31:25.000Z

Did you use CMake to build? It works for me on both MSVC 2013 and cygwin.
The Makefile in the directory itself may not work.

Answer 2 · 2015-12-08T08:54:42.000Z

Gotcha! The file is named SPIRVSubtarget.h and not SPIRVSubTarget.h, which will of course work on Windows since it's case insensitive, but not on Linux. As only SPIRVTargetMachine.h is calling it SPIRVSubTarget.h, I guess the name was meant to be SPIRVSubtarget.h. I'll write a patch.

Answer 3 · 2015-12-08T12:34:10.000Z

My bad :-) Thanks for fixing this.

Answer 4 · 2015-12-08T12:38:25.000Z

No problem! I would say this is one of the most common kind of errors when trying to build a Windows project on Linux/Mac OS. :-D