Pull requests status

Question

Pull requests status

Opened this issue a year ago · 20 comments

We created this issue for discuss on PR in general - blocking points/force merge or other topics.

The first question is do you need some in addition to merge these two PRs :
#77
#76
It's important to us to close entire Sprint 1...

The second topic based on merge of #79...
Here we just changed files name like pre-requirement for Sprint 2 and easier work without conflict...content is old for now
It is important to have prepared asap.

Thanks,
Marko

Answer 1 · 2023-10-17T11:43:21.000Z

It looks like @mkinsner merged #77 and #76.

I just approved #79.

Answer 2 · 2023-10-27T06:45:00.000Z

Hi @gmlueck @mkinsner,
Do you have possibility to force or speedup review process for provided PRs?
Reason is e.g 81 have dependecies for future works and would be grate to merge before continue...
Thanks in advance,
Marko

Answer 3 · 2023-10-27T10:45:05.000Z

Hi @imvucic,

We're at face-to-face meetings this week which is slowing things down, but I'll make sure to review these today.

Answer 4 · 2023-10-31T09:01:48.000Z

Hi @gmlueck @mkinsner
Could you please check/review https://github.com/KhronosGroup/SYCL_Reference/pulls list?
We should have forced review in order to close Sprint by tomorrow and provide some results for M2.
Thanks,
Marko

Answer 5 · 2023-11-01T09:13:10.000Z

Hi @mkinsner,

Should we wait review @gmlueck for final merge of #82?

Answer 6 · 2023-11-01T10:31:47.000Z

I just merged #82. I'll go over #85 in a few hours to approve/merge.

Answer 7 · 2023-11-01T11:35:36.000Z

#85 is approved and merged. Please let us know if anything else is blocking progress.

Answer 8 · 2023-11-02T08:22:35.000Z

From USM we have the last one #87, that would be grate to be merged and following our Sprint 2 plans.

Answer 9 · 2023-11-06T18:02:28.000Z

Hi @mkinsner @gmlueck,

We have added all Common Interface PRs and waiting review...
Also would be great to prioritize review of New skeleton for "Data Access" chapter : #91 to unblock next story's related.

BR,
Marko

Answer 10 · 2023-11-07T13:35:20.000Z

I've approved and merged #91 to unblock progress on the next chapter. Will review the common interface PRs shortly

Answer 11 · 2023-11-14T10:53:10.000Z

Hi @mkinsner @gmlueck
From our perspective we should prioritize review on New skeleton for "Expressing parallelism" chapter : #97
Could you please recheck?

Thanks,
Marko

Answer 12 · 2023-11-14T12:03:56.000Z

One more general comment...Tomorrow is last day of our Sprint 3...In order to close appropriately we should receive review on all topics from PR list : https://github.com/KhronosGroup/SYCL_Reference/pulls
We are aware of the conference allocation from your side this week, but if there is a possibility, please process

Answer 13 · 2023-11-16T20:57:02.000Z

All PRs have been approved and merged now, so thanks for making all requested changes so quickly

Answer 14 · 2023-11-29T08:31:23.000Z

Hi @mkinsner @gmlueck
Could you please check/review SYCL_Reference/pulls
For complete Data access chapter we need merge of #109.

Thanks,
Marko

Answer 15 · 2023-12-07T10:53:22.000Z

Hi @mkinsner @gmlueck @tomdeakin
As we approach the year-end, to ensure a smooth completion and alignment with our objectives, we've reached a critical phase where we are eagerly anticipating your valuable review on several major tasks:

Design confirmation of existing chapters :
Possible chapters adding in ref guide and new structures definition :

Your review and comments are crucial to ensure accuracy and alignment with our standards before finalizing the task, especially in part of adding new chapters for allocation more efforts and quality planning.

Thanks in advince,
Marko

Answer 16 · 2023-12-20T09:18:40.000Z

Hi @mkinsner,
We notice number of accumulated PRs without reviews...could you please share plans or availability for review in order that we finalize several chapters before end of 2023?

Best regards,
Marko

Answer 17 · 2023-12-20T22:45:24.000Z

Hi @imvucic,

I've now either approved and merged, approved (pending merge conflict resolution), or left comments on all of the open PRs. I'll monitor in the coming days and merge as the PRs are updated.

I'll be out of office next week and for a few days the week after, but will try to be active reviewing PRs again starting Jan 3.

Answer 18 · 2024-02-07T09:15:30.000Z

Hi @mkinsner @gmlueck @tomdeakin
We believe from Intellias side provided all PRs and covered final Cycle 2, for today is planned to close last Sprint 9.

Could you please provide here final comment and ensuring that the content provided is correct and complete, and consistent with the SYCL 2020 specifications and behavior?

Thanks in advanced,
Marko

Answer 19 · 2024-02-07T13:05:15.000Z

Hi @imvucic

I'm not aware of any remaining gaps, but also won't do a detailed comparison against the SYCL 2020 specification today. Has Intellias done a final analysis of the reference guide versus SYCL 2020, and believes that all gaps are closed (all SYCL 2020 API content is captured in the reference guide, and no SYCL 1.2.1 features which were removed in SYCL 2020 are in the reference guide)?

Thanks,
Mike

Answer 20 · 2024-02-07T16:01:51.000Z

Hi @mkinsner,

From Intellias we have done a final gap analysis in parallel and believes that all gaps are closed.
The question was only in the content if some smaller parts may have been overlooked, but we did everything according to the agreement and the regular closing of the 2nd cycle of gaps.
For now we will close Sprint 9, if something in addition please bring up here or comment in weekly meeting.

Thanks and Best regards,
Marko