KhronosGroup/Vulkan-LoaderAndValidationLayers

Should "actual + rdur" be "desired + rdur" in cube.c ActualTimeLate()?

bradgrantham opened this issue · 5 comments

uint64_t deadline = actual + rdur;

@mikes-lunarg, this related to your cube glitches maybe?

@mark-lunarg I don't think it is related. ActualTimeLate() is part of the VK_GOOGLE_display_timing demo embedded within cube, which my desktop system does not support.

@bradgrantham , @mark-lunarg , and @mikes-lunarg , I'll take a look at this (sounds like code that I wrote).

My understanding is that Keith Packard wrote VK_GOOGLE_display_timing support for at least one Mesa Vulkan driver (paid for by Valve). I think it's for AMD hardware on Linux, but I'm not certain.

@bradgrantham you are correct that there is a bug. As @karl-lunarg described, #2637 is a fix that we should take.

Rebased and pushed to Master. Thanks to all!