Make RingBuffer Send and Sync

Question

Make RingBuffer Send and Sync

Closed this issue 7 months ago · 5 comments

FrameDecoder is currently !Send and !Sync due to core::ptr::NonNull being as such.

I think it would be alright to add Send and Sync impls for RingBuffer as I don't see any way that memory held by the buffer could be aliased or any interior mutability used in the struct.
Could you please check this and consider making RingBuffer Send and Sync?

Answer 1 · 2024-02-18T10:40:05.000Z

I don't see why it shouldn't be Send + Sync. I'll add those impls.

Out of curiosity, how did this come up?

Answer 2 · 2024-02-18T10:50:10.000Z

Could you confirm that a16e38b resolves this issue before I make a new release?

Answer 3 · 2024-02-18T14:09:37.000Z

Yeah, thanks, that works!

chd-rs recently added support for CHDs that use Zstandard compression, and Chd lost the Send + Sync markers because FrameDecoder is kept as state.

In my image access crate I've been moving the Chd to another thread, but that broke because it's no longer Send.

Answer 4 · 2024-02-18T16:34:28.000Z

Released as 0.6.0 because other pending were potentially breaking based on crate features. So chd-rs will need to update their ruzstd dependency :/

Answer 5 · 2024-02-18T17:05:27.000Z

Thanks and no problem, it has to be made explicit on CompressionCodec anyway.