IVT lists protected internal methods such as OnAnalyzerConfigDocumentAdded

Question

IVT lists protected internal methods such as OnAnalyzerConfigDocumentAdded

KirillOsenkov opened this issue 5 years ago · 1 comments

probably shouldn't list these?

Answer 1 · 2021-06-18T01:06:06.000Z

IVT also lists usages of protected constructor on public abstract class:

C:\Ide\bin\Debug\Microsoft.CodeAnalysis.TypeScript.EditorFeatures.dll
=====================================================================
  Consumed in: C:\xxx\bin\Debug\Web.dll
    Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockRegistryCore Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockCore::scriptBlockRegistry
    System.Void Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockCore::.ctor(System.String,Microsoft.VisualStudio.Text.ITextBuffer,Microsoft.Web.Editor.ContainedLanguage.IContainedLanguageHost,Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockRegistryCore,Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.IScriptIdFactory,Microsoft.VisualStudio.Text.Editor.IEditorOptionsFactoryService,Microsoft.VisualStudio.Threading.JoinableTaskContext,System.Action`2<Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockCore,Microsoft.VisualStudio.Text.Editor.ITextView>)
    System.Void Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockCore::Update(System.String)
    System.Void Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockRegistryCore::LogScriptBlockRegisteredTelemetry(Microsoft.CodeAnalysis.Editor.TypeScript.ScriptContexts.ScriptBlockCore)