Kitura/swift-ubuntu-docker

Move vi code from kitura-ubuntu dockerfile to this repo.

rolivieri opened this issue · 3 comments

Move vi code from kitura-ubuntu dockerfile to this repo.

@rolivieri I had removed the vim package during this reflector for Dockerfile best practices:
832dde1

I did so to match the published Dockerfile best practices that says:

Avoid installing unnecessary packages
In order to reduce complexity, dependencies, file sizes, and build times, you should avoid installing extra or unnecessary packages just because they might be “nice to have.” For example, you don’t need to include a text editor in a database image.

However, in the end, this image needs to be usable by the team. Since this image is used to not only deploy swift apps, but to also test and debug, vi is a critical component.

@dsperling No worries, I remember that was one of the changes in the PR. I did not have a need for it either but it turned out that other team members have a need for vi as a critical component in this docker image.

this has been commited to master. Closing