Restore after save state fails because of direction being serialized as an object
bourdaisj opened this issue · 4 comments
Seems like direction is stored as a Float64Array, JSON.stringify serializes it as an JS object :(
Therefore when restoring we have a failure since it tries to feed an object into macro.setArray
I'll fix it
Good catch! Do you anticipate this being a fix into vtk.js or Glance? vtkObj.toJSON() implies the output should be JSON-serializable, but right now it definitely is not.
yeah I guess vtkObj.toJSON is broken right now? did not think about that.
And we may want to fix getState as well since it should return a representation that should be directly JSON-serializable (e.g., returning plain JS array instead of typed array where applicable)
we may have nothing to fix here in Glance indeed
🎉 This issue has been resolved in version 4.25.0 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀