KleoPetroff/react-webpack-boilerplate

no coverage?

Closed this issue · 5 comments

The problem

You are running unit tests without coverage.

Fair point, but I want to keep things simple. People using the boilerplate, me including, can integrate a coverage tool by their taste. I'll leave that choice to them. Also, most of the example code would most definitely change or be removed, so adding more tests to keep a high % of coverage, that will later be deleted seems like unnecessary extra work.

its your call, however i want to point out that there is no need to keep the % high for a boilerplate. Also, having nyc for coverage will keep things super simple.

I've thought about it this morning and you have a point - nyc is super simple to integrate and would indeed benefit the project. I may end up adding it after all. 😉

I'm reopening the issue.

i can submit a pull request

That would be great!