Add ability to ignore first probe value

Question

Add ability to ignore first probe value

Makhaira opened this issue 4 years ago · 5 comments

I have seen a number of reports across different printers and different probes where the first probe result of a "set" is inaccurate compare to the rest of the set of results. It would be great if there was a config variable in klipper where you could choose to ignore the first result in a probe.

E.G.

probe returns result of 0.2, 0.19, 0.19, 0.19, 0.19.

I am asking for klipper to ignore the first result in any subsequent calculations, the dataset becomes just 0.19, 0.19, 0.19, 0.19. This has the potential to remove the number of repeat probes required as there is confidence the first result is ignored.

Answer 1 · 2020-10-04T16:12:04.000Z

Hi @Makhaira,

It did not look like there was a Klipper log file attached to this ticket. The log file has been engineered to answer common questions the Klipper developers have about the software and its environment (software version, hardware type, configuration, event timing, and hundreds of other questions).

Unfortunately, too many people have opened tickets without providing the log. That consumes developer time; time that would be better spent enhancing the software. If this ticket references an event that has occurred while running the software then the Klipper log must be attached to this ticket. Otherwise, this ticket will be automatically closed in a few days.

For information on obtaining the Klipper log file see: https://github.com/KevinOConnor/klipper/blob/master/docs/Contact.md

The log can still be attached to this ticket - just add a comment and attach the log to that comment.

Best regards,
~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Answer 2 · 2020-10-05T12:27:42.000Z

You can use the median function instead of average. IMO the best approach is to use an even number of probes, as the median function will average around the middle.

For example:
0.18, 0.19, 0.21, 0.22
will discard 0.18 and 0.22 and average 0.19 and 0.21

Answer 3 · 2020-10-07T10:53:37.000Z

Thanks Sineos. I realise that is one solution, however many probe solutions now have such orecision/repeatability that you don't even need that many samples. I know that's true for the Omron inductive probes, and apparently for some of the microswitch based ones too. I realise this isn't a bug or a fault, but it would be a neat improvement to speed up probing.

…

On Mon, 5 Oct 2020, 13:27 Sineos, ***@***.***> wrote: You can use the median function instead of average. IMO the best approach is to use an even number of probes, as the median function will average around the middle. For example: 0.18, 0.19, 0.21, 0.22 will discard 0.18 and 0.22 and average 0.19 and 0.21 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#3397 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AOKLI6VHWZQKGHK47FCZOOLSJG3U3ANCNFSM4SDZHANQ> .

Answer 4 · 2020-10-29T00:12:55.000Z

Hello,

It looks like there hasn't been any recent updates on this
Klipper github issue. If you created this issue and no
longer consider it open, then please login to github and
close the issue. Otherwise, if there is no further activity
on this thread then it will be automatically closed in a few
days.

Best regards,

~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

Answer 5 · 2020-10-29T05:47:51.000Z

Will use median on even number probe