Bring to Inkscape Extensions Core
Opened this issue · 6 comments
This extension would work well as a core extension installed by default for all Inkscape users.
If you'd like to bring this extension to https://gitlab.com/inkscape/extensions/ with a merge request (it'll need to be upgraded to 1.0 and have a comparison test written) but would be a good addition.
Upstreaming this extension is a very good idea, and I was shocked that Inkscape doesn't offer this feature out-of-the-box.
@doctormo there's an upgrade for 1.0 in #25 now (it still needs some changes - see discussion).
The license of this extension (GPLv2) appears to be exactly what inkscape/extensions uses anyway (GPLv2). So unless there's an issue with the "or later" clause, or requirement for a CLA, anybody could upstream this - it doesn't have to be @Klowner.
I don't plan to do it myself, but I'd be very grateful if somebody did this.
It should only require a test to be written and potential cleanup.
Hi JayFoxRox: It's great to see this extension with 1.0 upgrades. I'm not sure which way round you mean for the GPLv2, we have GPLv2 or later and GPLv3 or later code in the extensions repository. I believe that your license is compatible, but we can double check. There is no CLA.
We can keep this issue open until you have a suitable student or other new volunteer who might like to do this. It should be pretty simple in terms of the merge request, but the writing of tests will be more of a challenge.
@doctormo I'm happy to take a look at this (if I get time). Is there a current guide on making extensions for v1, including tests? I have done some work on this for my own use (see #26), and found much of the doco was for pre-v1, and ended up looking at the InkScape source code for a lot of it.
It would be good to understand, for example, is Python 2 support required any more (the README suggests yes), but obviously Python 2 is end of life? Also, while asking questions, is there a migration guide? I have another project I'm looking to try and bring up to date, and getting a lot of DeprecationWarnings, but I'm not sure what a number of them mean (I don't know InkScape code very well obviously :) )
Cheers!
@sillyfrog here is a short migration guide for Updating your Extension for 1.0 and for testing you can start with TESTING.md in the Inkscape extension GitLab.
As a possible first step, could you make it available to the Extensions installer?
indeed this extension is one of the most important i know accross the web. would be a huge benefit