Kludex/bump-testclient

Replace `response.ok` with `response.is_success`

Opened this issue · 1 comments

I have a couple of unit tests like these:

response = client.post(Routes.JOBS, json=job_dict)
assert response.ok

Based on https://www.python-httpx.org/compatibility/#checking-for-success-and-failure-responses (and encode/httpx#543, encode/httpx#574) a replacement for this requests functionality in httpx exists with response.is_success

PR welcome.

I can guide you, if interested.