Kobzol/cargo-pgo

Reason for stdin(stdio::null)?

whatmatrix opened this issue · 4 comments

whatmatrix commented

I have a command-line app that I wishes to use PGO and BOLT. It takes a few inputs from stdin at the startup. It works well with cargo run.

cargo pgo seems to be overriding stdin by passing stdio::null().

Is it necessary for cargo pgo functionalities? cargo pgo run obviously works differently than cargo run due to this.

Kobzol commented

Hi, good point. I think that I did this only out of habit, but for cargo pgo run it doesn't make sense. Can you please try if this PR fixes your problem?

$ cargo install --git https://github.com/kobzol/cargo-pgo --branch pass-stdin
whatmatrix commented

Hi,

Thank you very much for being responsive! It works very well. I really appreciate your work!

Kobzol commented

No problem! I'm glad that it helped. I will release a new version with the patch soon if there won't be any other changes in the meantime.

Kobzol commented

Published 0.2.4 with this change.