Firmware '-1'

Question

Firmware '-1'

mainmind83 opened this issue 7 months ago · 36 comments

What happened?

Update to v1.35.1 and show firmware "-1"
GLEDOPTO Zigbee LED Controller W (pro)

{
"brightness": 241,
"linkquality": 149,
"power_on_behavior": "on",
"state": "OFF",
"update": {
"installed_version": 369176577,
"latest_version": -1,
"state": "idle"
}
}

What did you expect to happen?

Show new firmware?

How to reproduce it (minimal and precise)

1.35.0 to 1.35.1

Zigbee2MQTT version

1.35.1

Adapter firmware version

20230507

Adapter

SONOFF USB ZBDongle-P

Debug log

No response

Answer 1 · 2024-01-07T20:26:59.000Z

I get the same thing for the IKEA Parasoll sensors

Answer 2 · 2024-01-07T21:33:37.000Z

I am getting the same thing with 3 Sengled E21-N1EA

Answer 3 · 2024-01-07T21:41:05.000Z

It seems like it could be a more general error, not associated with a specific device... all of which there is no firmware available?

Answer 4 · 2024-01-07T22:13:24.000Z

I would say you are correct. The OTA does not work for the Sengled E21-N1EA but I see no errors coming up, just those listed and as an update in Home Assistant settings.

Answer 5 · 2024-01-08T00:53:53.000Z

I'm getting this as well for Sengled E1F-N5E bulbs.

If I go into Z2M and the OTA tab and click on "Check for new updates" for one of those bulbs I get the following error pop up:

OTA: Images currently unavailable for device 'E1F-N5E', hardwareVersion '1', manufacturerName sengled, {"fieldControl":0,"manufacturerCode":4448,"imageType":32977,"fileVersion":22}'

Answer 6 · 2024-01-08T06:12:46.000Z

Same here, for two Sonoff SNZB-02P devices.

Answer 7 · 2024-01-08T07:16:44.000Z

Go the same issue with some Sonoff devices.

Answer 8 · 2024-01-08T07:55:00.000Z

I got the same for 2 Namron devices: https://www.zigbee2mqtt.io/devices/4512700.html#namron-4512700

Answer 9 · 2024-01-08T10:29:08.000Z

Same for Ikea parasoll sensors

https://www.zigbee2mqtt.io/devices/E2013.html#ikea-e2013

Answer 10 · 2024-01-08T16:55:11.000Z

same with hive trv's

Answer 11 · 2024-01-08T17:55:51.000Z

To add: same here with Gledopto GL-C-009P…

Answer 12 · 2024-01-09T08:11:35.000Z

I found the same issue at #20678 for the EcoDim Eco-Dim.07/Eco-Dim.10

Answer 13 · 2024-01-09T08:20:24.000Z

I think Koenkk/zigbee-herdsman-converters#6843 introduced this bug.

Answer 14 · 2024-01-09T09:40:51.000Z

I think Koenkk/zigbee-herdsman-converters#6843 introduced this bug.

It should be marked as OTA update not available for this device...

Answer 15 · 2024-01-09T15:26:22.000Z

Koenkk/zigbee-herdsman-converters#6864

Already fixed, problem with HA (doesn't recognized negative number as "don't try to update"...), but Z2M should work around it as soon as this is merged.

HA PR home-assistant/core#107483

PS: Z2M still won't let you update even if HA says "go ahead", so it's only a feedback issue.

Answer 16 · 2024-01-09T16:22:18.000Z

Well, I would say -1 is still a version number. I think null or None should indicate "don't try to update"

Answer 17 · 2024-01-09T16:25:52.000Z

version -1 in software is equivalent to the moment the idea comes out of the head of the developer or project manager 😄 🤰

Answer 18 · 2024-01-09T16:40:48.000Z

@LarsStegman HA core wouldn't behave properly ("OFF") on all of these too. link
HA actually fails because it doesn't recognize "-1" as a version number (or any negative number)... and since it defaults to ON whenever it fails to compare... it reports "update available". The compare fault ultimately lies in the AwesomeVersion package used by HA.
-1 should at least always be less than 0 (which hopefully any valid version number aspires to be greater to) 😄

With the PR, Z2M will report current version as latest version in case no image is available and fix the issue. It just limits what the frontend could have done with the -1 special case; could have been used "as-is" in the future to handle "no image available" differently than "no update available" (what I had in mind @mainmind83 😁), but I guess if needed we can revisit the implementation at that time!

Answer 19 · 2024-01-09T19:03:11.000Z

Fixed in Koenkk/zigbee-herdsman-converters@5f26292, thanks @Nerivec

Changes will be available in the dev branch in a few hours from now.

Answer 20 · 2024-01-12T19:58:00.000Z

Why is it that there should be an update available but it's still showing as -1? I have an E1744 IKEA device that is on an old version. It's still showing as -1

Info 2024-01-12 11:52:02MQTT publish: topic 'zigbee2mqtt/bridge/response/device/ota_update/check', payload '{"data":{"id":"0xec1bbdfffe396590"},"error":"Failed to check if update available for '0xec1bbdfffe396590' (Cannot destructure property 'data' of '(intermediate value)' as it is undefined.)","status":"error","transaction":"hh8mg-5"}'
Error 2024-01-12 11:52:02Failed to check if update available for '0xec1bbdfffe396590' (Cannot destructure property 'data' of '(intermediate value)' as it is undefined.)
Debug 2024-01-12 11:52:02TypeError: Cannot destructure property 'data' of '(intermediate value)' as it is undefined. at getImageMeta (/app/node_modules/zigbee-herdsman-converters/src/lib/ota/tradfri.ts:15:18) at processTicksAndRejections (node:internal/process/task_queues:95:5) at isNewImageAvailable (/app/node_modules/zigbee-herdsman-converters/src/lib/ota/common.ts:398:18) at Object.isUpdateAvailable (/app/node_modules/zigbee-herdsman-converters/src/lib/ota/common.ts:387:29) at OTAUpdate.onMQTTMessage (/app/lib/extension/otaUpdate.ts:205:45) at EventEmitter.wrappedCallback (/app/lib/eventBus.ts:167:17)

Answer 21 · 2024-01-12T20:05:31.000Z

@88fingerslukee I just tried the update URL for IKEA https://fw.ota.homesmart.ikea.net/feed/version_info.json, it's currently not working. We'll need more checks to make that kind of error clearer.

Answer 22 · 2024-01-20T11:15:38.000Z

@Koenkk I know the next release is feb 1, because you mentioned it, but is there a certain schedule?

Answer 23 · 2024-01-21T21:04:29.000Z

Every 1st of the month!

Answer 24 · 2024-01-26T14:02:04.000Z

FWIW I have a Gledopto GL-C-001P (working as as a 003P) giving the same error. Is there a fix coming in Feb? At the moment I've turned off Automatic OTA checking in Zigbee2MQTT and 'skipped' the install message in HA.

Answer 25 · 2024-02-01T21:28:19.000Z

Koenkk/zigbee-herdsman-converters#6864

1 fixed on v1.35.2-1

Now showing unavailable with GL-C-008P 10951233

OTA: Images currently unavailable for device 'GL-C-008P', hardwareVersion '2', manufacturerName GLEDOPTO, {"fieldControl":0,"manufacturerCode":4687,"imageType":5141,"fileVersion":419508225}'

Answer 26 · 2024-02-01T23:01:44.000Z

I've updated to 1.35.2 today and still get these weird -1 firmware update notifications in home assistant.

Answer 27 · 2024-02-02T00:55:20.000Z

Same. just updated today.. still showing -1

Answer 28 · 2024-02-02T01:14:28.000Z

Same. just updated today.. still showing -1

Open Zigbee2MQTT and rescan/check for available OTA. Once scan/check is complete the -1 updates disappeared for me.

Answer 29 · 2024-02-02T06:19:23.000Z

thank you! that worked

Answer 30 · 2024-02-03T14:22:26.000Z

I confirm, after rescanning, the -1 errors disappeared.
Thank you!

Answer 31 · 2024-02-05T19:58:03.000Z

I have also updated to v1.35.2-1 and I believe it worked for 5 out of my 9 Eco-Dim.07 units, at least they are no longer listed in the "settings" - "updates" section.

For the remaining 3-4 units they are still in the list. I tried the suggested fix by @elderec without any luck. I have since also restarted HA a couple of times but that didn't have any effect.

Zigbee2MQTT version: Zigbee2MQTT version 1.35.2-1 commit: unknown
Coordinator type: EZSP v12
Coordinator revision: 7.3.1.0 build 0
Adapter: Sonoff ZBDongle-E USB Zigbee 3.0 USB Dongle Plus,EFR32MG21 + CH9102F Zigbee USB-Stick
Zigbee-herdsman-converters version: 18.25.1
Zigbee-herdsman version: 0.33.5

Answer 32 · 2024-02-06T09:08:05.000Z

I have also updated to v1.35.2-1 and I believe it worked for 5 out of my 9 Eco-Dim.07 units, at least they are no longer listed in the "settings" - "updates" section.

For the remaining 3-4 units they are still in the list. I tried the suggested fix by @elderec without any luck. I have since also restarted HA a couple of times but that didn't have any effect.

Zigbee2MQTT version: Zigbee2MQTT version 1.35.2-1 commit: unknown

Coordinator type: EZSP v12

Coordinator revision: 7.3.1.0 build 0

Adapter: Sonoff ZBDongle-E USB Zigbee 3.0 USB Dongle Plus,EFR32MG21 + CH9102F Zigbee USB-Stick

Zigbee-herdsman-converters version: 18.25.1

Zigbee-herdsman version: 0.33.5

What is the imageType of those devices? I added the firmware for imageType 60 which is probably why some of them are fixed.

Answer 33 · 2024-02-06T10:26:20.000Z

Thanks for looking into this! How do I check which imageType they have please?

I tried to update one of the units to the "-1" version and received the following log entry:

Info 2024-02-06 11:19:37Updating 'Hall | Belysning | Spotlights' to latest firmware
Debug 2024-02-06 11:20:38Update of 'Hall | Belysning | Spotlights' failed (Error: OTA: Device didn't respond to OTA request)
Info 2024-02-06 11:20:38MQTT publish: topic 'zigbee2mqtt/Hall | Belysning | Spotlights', payload '{"brightness":178,"linkquality":255,"power_on_behavior":null,"state":"ON","update":{"installed_version":16869200,"latest_version":-1,"state":"available"},"update_available":null}'
Info 2024-02-06 11:20:38MQTT publish: topic 'zigbee2mqtt/bridge/response/device/ota_update/update', payload '{"data":{"id":"Hall | Belysning | Spotlights"},"error":"Update of 'Hall | Belysning | Spotlights' failed (OTA: Device didn't respond to OTA request)","status":"error","transaction":"a4bx9-1"}'
Error 2024-02-06 11:20:38Update of 'Hall | Belysning | Spotlights' failed (OTA: Device didn't respond to OTA request)

Answer 34 · 2024-02-06T17:42:55.000Z

Thanks for looking into this! How do I check which imageType they have please?

I tried to update one of the units to the "-1" version and received the following log entry:

`

Info 2024-02-06 11:19:37Updating 'Hall | Belysning | Spotlights' to latest firmware

`

`

Debug 2024-02-06 11:20:38Update of 'Hall | Belysning | Spotlights' failed (Error: OTA: Device didn't respond to OTA request)

`

`

Info 2024-02-06 11:20:38MQTT publish: topic 'zigbee2mqtt/Hall | Belysning | Spotlights', payload '{"brightness":178,"linkquality":255,"power_on_behavior":null,"state":"ON","update":{"installed_version":16869200,"latest_version":-1,"state":"available"},"update_available":null}'

`

`

Info 2024-02-06 11:20:38MQTT publish: topic 'zigbee2mqtt/bridge/response/device/ota_update/update', payload '{"data":{"id":"Hall | Belysning | Spotlights"},"error":"Update of 'Hall | Belysning | Spotlights' failed (OTA: Device didn't respond to OTA request)","status":"error","transaction":"a4bx9-1"}'

`

`

Error 2024-02-06 11:20:38Update of 'Hall | Belysning | Spotlights' failed (OTA: Device didn't respond to OTA request)

`

It should be there in the debug logs somewhere I guess if you check for an update.
Example:

2024-02-06 18:39:54Received Zigbee message from 'Eettafellamp', type 'commandQueryNextImageRequest', cluster 'genOta', data '{"fieldControl":0,"fileVersion":16869200,"imageType":60,"manufacturerCode":4714}' from endpoint 1 with groupID 0

Answer 35 · 2024-05-19T19:37:21.000Z

After updating to 1.37.1, I received this message again for seven Ikea devices.
OTA-Updates option "IKEA TRADFRI OTA use test url" is not activated.

Answer 36 · 2024-06-07T18:02:18.000Z

Even with version 1.38.0, the -1 entries did not disappear automatically. But I have found out that they are gone with a manual check for updates via the OTA menu. Or even newer versions were suggested for some devices.