KoltesDigital/shadertoy-exporter

TypeError: c.resize is not a function

Chaotnix opened this issue · 11 comments

Chaotnix commented

I tried running the shadertoy-exporter-1.4.0.exe on Windows 10, Java 1.8.
I get the error 'TypeError: c.resize is not a function' as soon as i click on export.

FullstackJack commented

There is no Java here, it's built with Electron which is JavaScript.

tdhooper commented

This is probably because shadertoy removed their internal resize function, I had the same issue with my frame exporter plugin, here's how I fixed it there if anyone needs a reference implementation:

tdhooper/shadertoy-frame-exporter@5f73b10

  • ❤️1
Chaotnix commented

Thanks for the clarification.
Unfortunately I am not able to fix it by myself, because I can't even compile the code in VS Code.
There are always unresolved dependancies.
Maybe be I will try again, when I have some better understanding how npm, jspm an the other tools work.
Till then I will use tdhooper/shadertoy-frame-exporter. It does a great job.

KoltesDigital commented

Sorry for being late. I've fixed the resizing part. 9d471c3 @tdhooper I tried to use your change, but after all I copied the code executed on going fullscreen, this has the advantage of not visually resizing the canvas!

However, indeed the build process is now broken. I'll have a look at it.

  • ❤️4
benoitmar commented

Hello all,
I downloaded yesterday the shadertoy-exporter-1.4.0.exe.
I still get the c.resize error. Do you plan to make a new build with the fix ?

Thank you for making this tool, shadertoys rocks !

Hitthesurf commented

Hello all, I downloaded yesterday the shadertoy-exporter-1.4.0.exe. I still get the c.resize error. Do you plan to make a new build with the fix ?

Thank you for making this tool, shadertoys rocks !

I got this today, for windows 10, and I get the c.resize error.

kilik128 commented

same here if somethink's have make new build it's can be good

  • 👍1
vladimirmujagic commented

Any update regarding this issue? It's currently unusable

sdedovic commented

I was able to build and use on MacOS 12 (Monterey) after blowing away the package-lock.json file and upgrading electron-builder to "^21.2.0".

  • 🚀1
vladimirmujagic commented

Thank you very much, it solved the issues. I was using released windows executable, works both on Linux and Windows when "building from source".

  • 👍1
KoltesDigital commented

Sorry for being late again...

I finally took time to fix the CICD. As mentioned, the code was fixed months ago, but the CICD didn't actually published anything.

A working version is now available! https://github.com/KoltesDigital/shadertoy-exporter/releases/tag/1.5.4

But, well, this project is so old. Libraries are outdated, UI isn't friendly. If someone has time to take it over...

  • 👍1