Github rate-limiting breaks everything.
Opened this issue · 4 comments
Version Number
2.0.2
What branch are you on?
master
Describe the Bug
Hello, I think there's a serious issue with how Kometa works.
I was doing a huger number of restart to test my script, which ended in errors like this :
Took me an hour to figure out that it was GitHub that was rate-limiting me because of endless reboot to test my yaml config.
File(s) should really be cached up so that issue like this doesn't arise.
Also, the GitHub error should be shown on console clearly.
Thanks for reading.
Relevant Collection/Overlay/Playlist Definition
No response
Logs
No response
each translation file is already set to only be loaded once per run of Kometa ill try and add some better error reporting
each translation file is already set to only be loaded once per run of Kometa ill try and add some better error reporting
What is your stance on caching the file(s) ? This would allow to Kometa to still run even if GitHub is not available.
its cached though the run so it only pings github once per run for the translation file this ensures that any changes to the translation are picked up by kometa
its cached though the run so it only pings github once per run for the translation file this ensures that any changes to the translation are picked up by kometa
Yeah sure, but any subsequent run so close to each other, this shouldn't happen.
And even, honestly, if the server isn't available, it would seem sane to just use whatever is the latest local cached file available. For everything, not just translation. I'm assuming if GitHub is down, nothing will run.