KomodoPlatform/komodo-wallet-mobile

volume of bids in orderbooks are wrong

Opened this issue · 4 comments

cipig commented

example from GLC/LTC orderbook:
image

this are the correct values (from same orderbook on Desktop)
image

all bids have a wrong volume, the asks are fine
idk how this can happen, since there is no need for any calculations to show the correct values, they can simply be taken from the answer of orderbook call as is, without the need to do any calculations at all (just switch base and rel in orderbook call if you need the values the other way around)

also, in the above orderbook (the wrong one from mobile), the prices show more then 8 decimals (9 or 10)... i thought that we are limited to 8 decimals, so looks like a bug too... and very likely also related to wrong/unneeded calculations

i also have another problem on mobile: orderbook for eg LBC/KMD does not load at all (just shows a spinning circle), while KMD/LBC loads fine... could also be related to the same issue

smk762 commented

@CharlVS this issue should be resolved before next release - we just had another report in Discord and I've confirmed locally as still existing. Looks like a calculation inversion, hopefully a simple fix.
image
image

@cipig do you recall if the order book on mobile was previously showing the correct volumes for the bids?

I've found the bug, but it's code that was last changed years ago so it might just be a red herring with a deeper (more recent) cause.

cipig commented

do you recall if the order book on mobile was previously showing the correct volumes for the bids?

I don't know, sorry. I am using Desktop and only looked into this because a user reported it to me.

do you recall if the order book on mobile was previously showing the correct volumes for the bids?

I don't know, sorry. I am using Desktop and only looked into this because a user reported it to me.

No problem. Regardless, thanks for reporting it.