Memory leak in server.py

Question

Memory leak in server.py

Closed this issue a year ago · 5 comments

We ran into a memory leak in Kong Plugin Server that can be reproduced as described in https://github.com/vtlkvl/kong-python-pluginserver-memory-leak. We figured out that for each plugin call the messaging queue is added to PluginServer.events in PluginServer.handle_event, but PluginServer._step and specifically removal of the queue is done just for the last plugin. So if you have 10 plugins, 10 queues will be added to PluginServer.events, but just 1 will be deleted and 9 will remain in the memory and never get GCed. As a result PluginServer.events will grow until OOM.

Answer 1 · 2023-06-17T15:53:56.000Z

@fffonion I've got a fix for the issue. Can I get write access to push a feature branch to make a PR?

Answer 2 · 2023-06-20T03:53:52.000Z

@vtlkvl we usually don't grant access to community contributers, please creeate a fork and create PR from there : ) Feel free to ping me when it's ready.

Very good analysis on the memory issue btw 👍

Answer 3 · 2023-06-20T07:54:28.000Z

@fffonion I've made a PR. Once it is approved and merged, how long does it take to get a new version?

Answer 4 · 2023-06-20T07:58:05.000Z

@vtlkvl I will release a new version once the PR is merged!

Answer 5 · 2023-06-20T09:30:41.000Z

It should be resolved in Kong PDK 0.35.