Konijima/PZ-Community-API

ModSettingAPI: Convention correction needed

Closed this issue · 0 comments

Konijima commented

File:

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 11 in 4d3c604

ModSettingAPI.ValueType = require("ModSettingAPI/ModSettingValueType")

should be more clear what it do and follow convention
function ModSettingAPI.CreateModSettingSection(modID, sectionName)

same for

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 15 in 4d3c604

function ModSettingAPI:createSection(modID, sectionName)

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 54 in 4d3c604

function ModSettingAPI:getSection(modID, sectionName)

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 61 in 4d3c604

function ModSettingAPI:getSettingValue(modID, settingName)

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 71 in 4d3c604

function ModSettingAPI:setSettingValue(modID, settingName, value)

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 79 in 4d3c604

function ModSettingAPI:getOrCreateSandboxSection(sectionName)

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 88 in 4d3c604

function ModSettingAPI:getSandboxValue(sectionName, settingName)

PZ-Community-API/Contents/mods/CommunityAPI/media/lua/client/ModSettingAPI/ModSettingAPIClient.lua

Line 98 in 4d3c604

function ModSettingAPI:setSandboxValue(sectionName, settingName, value)