Kord-Extensions/kord-extensions

Add minValue and maxValue to int/decimal argument converters

Galarzaa90 opened this issue · 4 comments

Galarzaa90 commented

Summary

Add minValue and maxValue options to tIntConverterBuilder and DecimalConverterBuilder and derivatives.

They are defined here in the documentation: https://discord.com/developers/docs/interactions/application-commands#application-command-object-application-command-option-structure

And they were added to Kord since: kordlib/kord@4a73bfa

Current Behaviour

It is not possible to use these options, so these validations must be done after receiving the interaction with the validate option. While this allows more customization in error messages, it means receiving a command interaction that will be "rejected" by the bot.

Preferred Behaviour

Being able to use this option would mean that these options will be validated on the client's side, meaning you wouldn't receive the command interaction message if the numbers are invalid.

boring-cyborg commented

Hello, and thanks for opening an issue! As this is the first time you've created an issue on this repository, we'd just like to offer you a warm welcome to the project, and the following pointers:

  • Most importantly, all issues must adhere to our Code of Conduct. Please give it a quick read if you haven't already.

  • While our team is passionate about the projects we've created here, we're all volunteers. Please don't be offended if it takes time for us to get to your issue - we'll be here as soonas we can be!

  • Please provide as much information as possible when asking a question, reporting a problem, or submitting a feature request. This will help us to address your issue quickly and efficiently. If you forgot to add some information, no worries - feel free to edit the issue and add anything you missed!

    Thanks for contacting us! If you have any further questions, please feel free to join us on Discord in the #dev-kotdis channel (or #kordex-discussion for Kord Extensions projects), or to contact a staff member directly.

gdude2002 commented

This has been added, but could do with some gentle poking - please verify.

Galarzaa90 commented

Everything seems to be working fine 👍🏼

gdude2002 commented

Thanks for the confirmation o7