Kotlin/kandy

Add "positional categorical: functions with `vararg` (instead of list of categories)

AndreiKingsley opened this issue · 4 comments

AndreiKingsley commented

Add an analogue for all existing functions that create positional scales with vararg of categories instead of list of categories.

  • PositionalMappingParameters<*>.categorical()
  • Scale.Companion.categoricalPos

https://github.com/Kotlin/kandy/blob/main/kandy-api/src/main/kotlin/org/jetbrains/kotlinx/kandy/dsl/scale.kt

lucas-watkins commented

Hello, is this issue still available?

lucas-watkins commented

May I submit a PR? All the tests are passing locally and I've added 2 new tests that deal with varargs specifically.

  • 👍1
AndreiKingsley commented

Yeah, sure!