Kralizek/AWSSecretsManagerConfigurationExtensions

Newtonsoft.Json is a dependency

Closed this issue · 2 comments

Hello,

Currently the NuGet package lists Newtonsoft.Json (>= 13.0.1) as a dependency.

Based on PR #71, it should not be in use, although it is still referenced in the Test .csproj and used in the SecretsManagerConfigurationProviderTests.cs test class.

Is there a specific reason to keep using the Newtonsoft.Json in that class, or it's just a leftover from the System.Text.Json migration?

Version: 1.7.0

The migration to STJ was merged but not released, this is why 1.7.0 still references NJ.

As for the tests, it shouldn't matter as unit tests are not reflected in the package.

Thank you for the quick answer, all clear now!