The toolbar's height is too big and isn't the same as in the settings
Closed this issue Ā· 3 comments
Hello there, it's me again š.
The toolbar is too big for this website. The fix would be adding a
min-height: `${height}px`Another thing is that the height in the iframe is not the same as what I set in the settings. The height in settings is 42px, but in the iframe it is 41px as seen in eruda.
Hi! How are you doing?
Nice catch, thanks for reporting it. I'll investigate it to include the fix in the next update.
I'm fine, thank you. I hope you are too.
No biggie, no rush š.
Hi @MilaMurry! I hope youāre doing great. I havenāt been able to work on the add-on in the past few months. I had to move to another city and didnāt have access to my computer, but I do now and am happy to keep improving the add-on. Iām focusing on fixing bugs first and then gradually working on new features.
The toolbar size issue on that website was resolved some time ago. Regarding the inconsistency between the height set in the settings and the actual toolbar height: on most sites, the add-on will display at the correct height. However, for some sitesāespecially those in Desktop modeāthe add-on needs to calculate the height based on window.visualViewport.scale. The result isnāt always a whole number, so I use Math.floor() to round it down.
I tested several sites and couldnāt find one where the actual size differs from the set height. If you remember the specific site with the inconsistency and would like to share it, I could try rounding the number up instead of down. If the inconsistency no longer occurs, or if the difference is minor, we could consider this issue resolved.