Conflict maxUnreachableDepartures

[mazim-co]

Bug description
As soon as I add a number of maxUnreachableDepartures (e.g. 3) it is not showing maxReachableDepartures anymore.

Module config

{    
module: "MMM-PublicTransportHafas",
		position: "top_right",
			config: {
				stationID: "732872",                  
				stationName: "Albertinenstraße",   
				direction: "",                    
				excludedTransportationTypes: [], 
				ignoredLines: [],                
				timeToStation: 7,
				showAbsoluteTime: false,
				displayLastUpdate: false,         
				maxUnreachableDepartures: 3,     
				maxReachableDepartures: 5,        
				showColoredLineSymbols: true,    
				customLineStyles: "berlin",             
				showOnlyLineNumbers: true,   
				showTableHeadersAsSymbols: true, 
				useColorForRealtimeInfo: true,  
				tableHeaderOrder: [ "line", "direction", "time" ]
				}
},

Screenshots

maxUnreachableDepartures: 3,     
maxReachableDepartures: 5,

maxUnreachableDepartures: 0,     
maxReachableDepartures: 5,

Additional context
It is working properly if I'm not using the option maxUnreachableDepartures

[KristjanESPERANTO]

Thanks for the good description of the issue.

With my last commit it should be solved. Please update the module and check whether it works now.

By the way: Have you created an extra css file for berlin? The line customLineStyles: "berlin" indicates this. I would be interested in what you defined there.

[mazim-co]

Thanks for the quick response. Unfortunately the changes doesn't fixed the issue. It is still the same weird behavior. It feels it has a conflict with the timeToTravel option. You can may test it with my stationID: 732872.

Yes, I created a full stylesheet for berlin lines which include all public transportation. I'm happy to share that with you. :) Just created a PR.

[mazim-co]

Oh, never mind. I missed to perform a npm install after git pull 😅. Everything is working as expected. Thank you.

[KristjanESPERANTO]

Nice that it works 🙂

[mazim-co]

Hi Kristjan - just noticed that the issue appears again. It was working for 4-5 hours.

[KristjanESPERANTO]

I'll see if I can take a closer look at it over the weekend.

Of course, I am also grateful for participation 🙂

[KristjanESPERANTO]

The problem was that there are very very many departures at Alexanderplatz. And therefore too many departures during the lead time.

I solved it by setting the lead time lower by default and adding a dynamic adjustment. So at stations with a lot of departures the lead time will be reduced and at stations with few departures the lead time will be increased.

[mazim-co]

Just want to say thank you! It works like charm - you rock 💪

[KristjanESPERANTO]

Thanks for the motivating feedback 😀