CI/CD: format convention (eslint, GH action)
mefengl opened this issue · 9 comments
Do you have any format config files to share?
I think this issue can be easily solved by asking ChatGPT.
No I didn't configure anything yet, I'm looking at the node.js to npm action though
GH action can be like:
name: ESLint
on:
push:
branches:
- main
pull_request:
branches:
- main
jobs:
eslint:
runs-on: ubuntu-latest
steps:
- name: Check out repository code
uses: actions/checkout@v2
- name: Set up Node.js
uses: actions/setup-node@v2
with:
node-version: 16
- name: Install dependencies
run: npm ci
- name: Run ESLint
run: npm run lint
@adamlui
the
}
}
}
issue you mentioned can be done by minified feature provided by tools like esbuild, it even compress them into one line
Additionally, it would be nice to enable the "autodelete" branch after it has been merged. This option can be turned on in the repository settings.
@adamlui the
} } }issue you mentioned can be done by minified feature provided by tools like esbuild, it even compress them into one line
Yes I know, I said userscripts don't compress so you should considering one line style and no semicolons for those projects
Ok, I will try to add this rule in the eslint config
Ok, I will try to add this rule in the eslint config
Wait a large commit is pushing that includes eslint's dependencies, you should make changes after the change
I won't add that rule cause I don't find a rule like that
maybe need further research
Additionally, it would be nice to enable the "autodelete" branch after it has been merged. This option can be turned on in the repository settings.
Ok it has been activated