Kuenaimaku/Hex-Size-Support

[BUG] Hex Borders + Backgrounds still visible in Fog of War

Opened this issue · 1 comments

msprijatelj commented

Describe the bug:
When the borders and "fill border contents" are enabled in Hex Token Size Support, tokens in the Fog of War still display their borders and fills.

Steps to reproduce:

  1. Enable "Always Show Border" and "Fill Border Contents" in the Hex Token Size Support settings.
  2. Create a new scene with Token Vision and Fog Exploration enabled.
  3. Create a new wall.
  4. Create a token on one side of the wall with Vision Enabled, Basic Vision, Vision Range set to be large enough to see most of the Scene.
  5. Create another token on the other side of the wall.
  6. Select the token from Step 4 (the one with vision enabled).
  7. Observe that the borders + fill of the token from step 5 is visible from behind the wall, even if the token image itself is not.
  8. Move the token from Step 4 so that it can reveal Fog of War behind the wall, then move it back to its initial position.
  9. Observe that the Borders and Fill are still visible in the explored area.
  10. Select the token from Step 5 and move it so that it's still obstructed by the wall, but in a different position.
  11. Select the token from Step 4. Observe that it can see the border and fill from the moved token has changed position (So it's not just a "last known position" issue).

Expected Behavior:
A token hidden by fog of war or obstructed line of sight will also have its borders and fill hidden.

Screenshots:
Although this screenshot only includes allied tokens, it also affects neutral and hostile tokens.
image

Additional Information:
While this may not be supremely important for a system like Lancer (for which this module may have been initially created), it may affect other systems using Hex Size Support that do care about Fog of War.

Contact Info:
Valkyrion#6196

Kuenaimaku commented

To add more on the issue - this is only for the GM as they have visibility of tokens no matter what. I feel like this is due to how everything is currently hovered technically when Always Show Borders is set to true. some more interesting logic involving checking controlled tokens may be the solution.