Getting 404 on /authenticate after updating to v22.0.0
Closed this issue · 8 comments
For bug reporting only! If you're posting a feature request or discussion, please ignore.
Expected Behavior
App installation should work and authenticate the shop
Current Behavior
Getting 'There's no page at this address' on /authenticate
Failure Information
Uninstall webhook is working, but installation fails for new and existing shops with 404 error on Shopify store.
Steps to Reproduce
- Create new test shop or uninstall the app from the shop
- Try to install the app
- Authentication fails and Shopify throws 404 error
- Latest version of this repo is used
Context
Please provide any relevant information about your setup. This is important in case the issue is not reproducible except for under certain conditions.
- Package Version: v22.0.0
- Laravel Version: 11.20.0
- PHP Version: 8.3.12
- Template Engine: Blade
- Using a toolset (Docker, Laradock, Vagrant, etc.): No (Nginx based server)
Failure Logs
There are no errors related to this in the log file
I'm also facing this issue
I hadn't seen this topic open and commented on it in the PR. #361 (comment)
Hey, I just created a fix that works for me. I hope it can help you guys
I commented in the pull request, the issue was actually something else.
At the moment, this problem can be easily solved by:
Publishing the resources with php artisan vendor:publish
Editing the file resources/views/vendor/shopify-app/auth/fullpage_redirect.blade.php
Then, remove line #7.
Although in this case, both solutions are suitable, the result will be the same.
Hi @jsalguero94 and @enmaboya
Thank you for providing the quick fix. I tried with @enmaboya solution to remove a line from fullpage_redirect.blade.php and it worked.
Waiting for @Kyon147 to check and merge the PR and release it.
I will close this once the solution is released.
Just a contribution, it worked for me as well :).
The minor release with this fix is now out.
https://github.com/Kyon147/laravel-shopify/releases/tag/v22.0.1