LBRNZ/ReqIFSharp_PlusObjects

ReqIFSharp

Opened this issue · 2 comments

Dear @LBRNZ,

I see that you've created a fork of the reqifsharp repository, fantastic! Today I made a new release (version 3.0.0), seems the Tool extensions were not being handled properly. I also fixed some other small issues and cleaned up some code.

I have not yet looked at your code, but from the readme file i see that you added a capability to be able to load embedded objects that are included in .reqifz file and referred to in XHTML data objects. Would you be interested in contributing this to reqifsharp itself?

Regards, Sam

LBRNZ commented

Hi Sam,
I would be interested to contribute my code. I would have to clean it up a little before contributing. I'm new to the Github game so how would I contribute my part?

Greetings Marc

LBRNZ commented

I looked into my code and saw, that I removed the compatiblity for NET Standard 2.0 and 1.6. I created a class for the embedded objects:

    public class EmbeddedObject
    {
        public string Name { get; set; }
        public string ImageName { get; set; }
        public MemoryStream ObjectValue { get; set; }
        public Bitmap PreviewImage { get; set; }

    }

That works fine for NET 4.5 The problem is that NET Standard 2.0 supports Bitmap only with an additional package und NET Standard 1.6 doesn't support Bitmap at all. Possible solution would be to also load the previewImage into a MemoryStream and the user would have to deal with how to display the image. What do you think?