LLNL/merlin

[FEAT] Report missing sample file

Closed this issue · 3 comments

🚀 Feature Request

Report missing sample file. If I make a typo, the file name in the samples section may not match the file name in my samples generation command. Merlin responds by silently not doing anything. I think it would be better to say "Sample file my_samples_1024.npy not found" or something of that sort.

@shlanger can you give us more details on how to duplicate this? Feel free to edit the text body of this issue.

EDIT: I think I understand, will look at fixing this

@shlanger When I run this (using feature_demo and changing the samples filename) in merlin 1.6.1, I get the error:

[2020-06-08 13:08:35: ERROR] [Errno 2] No such file or directory: 'feature_demo_20200608-130832/merlin_info/samples.npy'

...which seems like the right error to me.