LNST-project/lnst

lnst.Slave.Job.py: missing json keyword when passing argument to exec_cmd()

Closed this issue · 3 comments

There's a bug at following line:

stdout, stderr = exec_cmd(self._what["command"], self._what["json"])

The self._what["json"] value is passed as value of die_on_err argument, which makes every command running through this method return with sucess. Instead the value should be passed with the keyword, that is exec_cmd(...json=self._what["json"])

Good catch, I guess this has been impacting us from the start that all host.run("<shell command>") calls always passed?

Sent a patch for review, link

Fixed by commit 7448449