LOOHP/ImageFrame

AnimatedFakeMapManager using an unreasonable amount of server tick since 1.7.3 update

Closed this issue · 10 comments

Ever since updating to 1.7.3 ImageFrame::Task: com.loohp.imageframe.objectholders.AnimatedFakeMapManager$$Lambda$7623 (interval:1) is taking up a large portion of the server tick (24.01% on the latest timings report) despite the server not having any animated maps.

It would be nice if all animation functionality could be disabled in the configuration, since we're not actually utilizing it on the server.

LOOHP commented

Can you post the timings report here so I can take a closer look?

Can you post the timings report here so I can take a closer look?

Sure - https://timings.aikar.co/dev/?id=1e3b2f9daa31423c8a93ca36a8090a03

LOOHP commented

Do you have spark? Can you do a report with spark as well? It is a lot more in-depth.

LOOHP commented

image

It seems to be not loading for me.

It seems to be not loading for me.

I guess the link expires or something - here's a new one https://spark.lucko.me/m6MGwaK8Bi

Also a screenshot in case it expires again before you get to see it

image

LOOHP commented

Can you give this custom build of ProtocolLib a try to see if it is any better in performance?
Please do another spark report with it.

https://drive.google.com/file/d/1ZqgjhkTasv70lG02ascj8RWRitEOQ6xQ/view?usp=share_link

https://spark.lucko.me/dn7KKec43k

Noticeably better, but still using way more of the server thread than all the other plugins combined.

Before:
image_2023-04-09_00-06-33

After:
image_2023-04-09_00-14-15

It does seem to be better,

LOOHP commented

Emm I would like a closer look at the new report. Unfortunately it seemed to have already expired despite me arriving in just 2 minutes haha..

LOOHP commented

Closing this for inactivity, for now.