Add a test script?

Question

Add a test script?

pdeffebach opened this issue 5 years ago · 4 comments

Many of the examples in this are broken, for example in the balance test, the guide instructs us to do

bal.text(treat ~ foreign, data = mtcars)

Despite the fact that neither treat nor foreign exist in the mtcars dataset. Looking through the code-base, there doesn't seem to be an automated testing for this repository. Is this something on the radar?

khwilson commented 3 years ago

Done!

Answer 1 · 2019-11-11T19:31:16.000Z

Hmm, good catch. I've corrected that particular error, but automated testing would be very cool if possible. I'm not sure how feasible it is. Does anyone know?

Answer 2 · 2019-11-11T19:32:19.000Z

Which other pages are broken, by the way? I've tested quite a few recently and they've worked fine. At most they should require a package install.

Answer 3 · 2019-11-11T19:33:44.000Z

It's possible, but a bit more of a pain. There are methods like Python's doctests (liberally employed by Sage) and examples like sklearn's exceedingly wonderful documentation. The big problem is the assumed imports and data loads. But definitely totally possible to write for all open source languages. Stata, SAS, etc will be basically impossible. Kevin

…

On Mon, Nov 11, 2019 at 2:32 PM NickCH-K ***@***.***> wrote: Which other pages are broken, by the way? I've tested quite a few recently and they've worked fine. At most they should require a package install. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#6?email_source=notifications&email_token=AALU5ERJO5EGFTI3T3AYC3DQTGXMHA5CNFSM4JLZSD52YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDX3WJQ#issuecomment-552581926>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AALU5EU67VNYBZECQTLT2DTQTGXMHANCNFSM4JLZSD5Q> .