LUMIA-Group/rasat

model_cls_wrapper is not used

Dongfeng-He opened this issue · 1 comments

Dongfeng-He commented

Hi, @JiexingQi, I notice that model_cls_wrapper is not used when PICARD is enable, which is different from the implementation of PICARD. Will PICARD work if we don't wrap the model with model_cls_wrapper?

The code references are listed below:
RASAT implementation: https://github.com/LUMIA-Group/rasat/blob/main/seq2seq/run_seq2seq.py#L170
PICARD implementation: https://github.com/ServiceNow/picard/blob/main/seq2seq/run_seq2seq.py#L162

Dongfeng-He commented

The model_cls_wrapper is used in eval_run_seq2seq.py.