LabSid-USP/RUBEM

Fix error in the implementation of the Total Discharge equation

Closed this issue · 0 comments

Describe the bug

There is an error in the implementation of the total discharge equation $Q_t = x \cdot Q_{t-1} + \frac{0.001 \cdot (1 - x) \cdot A \cdot Q_{Tot}}{days \cdot 24 \cdot 3600}$, ("INITIAL_SOIL_CONDITIONS", "T_ini") was used instead of the parameter ("CALIBRATION", "x").

The current implementation looks like this:

self.runoff = (
self.config.getfloat("INITIAL_SOIL_CONDITIONS", "T_ini")
* self.Qprev
+ (1 - self.config.getfloat("INITIAL_SOIL_CONDITIONS", "T_ini"))
* self.Qt
)

But it should be like this, according to the equation available in Overview - Model Formulation - Total Discharge:

 self.runoff = ( 
     self.config.getfloat("CALIBRATION", "x") 
     * self.Qprev 
     + (1 - self.config.getfloat("CALIBRATION", "x")) 
     * self.Qt 
 ) 

To Reproduce

  • N/A

Expected behavior

  • N/A

Screenshots

  • N/A

System information

  • N/A

Additional context

  • N/A