Laravel-Lang/lang

Roadmap v3

caouecs opened this issue ยท 20 comments

Hello,
the aim of this project is the translation of Laravel files, all Laravel versions, and just translations.

For the version 3 :

  • new name for Composer : caouecs/laravel-lang
  • translated files in src directory
  • documentation

You forgot about moving all the translations into the new src folder (Major change).

No, because for me, this project is just for files of translation, readme and todo list. The script for todo list will be on another project.

So you Will be able to use this project for your own projects, without dependencies or constraints.

Even if this package contains only translation files, it needs to follow some conventions.

NOTE : The changes mentioned above aren't major changes, so the version will still v2.

The idea behind the src folder is very obvious and explains itself => This is the main folder and it contains all translations.

As a dependency that i use for my package, it's an assurance that is not gonna fail on me like the case when you added the script folder.

You can keep the script folder with this solution and you can create even more folders and stuff without breaking other packages, because everyone gonna use directly the src and it's 100% gonna have only the locales and their translations (and of course, without files like README.md, TODO.md and stuff).

For more details: #526

For the sake of maintainability, this is the best solution that i can tell. If you have a good reason or solution for everyone, please share it with us.

done ;)

Is there any progress ?

Hello,
sorry but I'm on vacation ;)

changelog updated

How about adding the CHANGELOG.md, LICENSE.md and CONTRIBUTING.md files and keep the README.md file skinny and clean ?

Like this repo: https://github.com/thephpleague/skeleton

You can

Hi @caouecs, great work ๐Ÿ‘

About the version for Laravel 5.2 with uppercase on variables, nice feature to have in Laravel, i didn't know that ๐Ÿ˜„.

But, i prefer to stick with the default en translations (Like this validation.php file or this one) offered by Laravel and also it's compatible with Laravel 5.1.

I do two versions, one for Laravel 5.1 and one for Laravel 5.2 and uppercase ? ;)

I mean that the caouecs/laravel-lang:v3 is going to be compatible with Laravel 5.1 & 5.2 if you keep the lowercase :attribute (backward compatibility).

Maybe, but I think a v3.1 can just be for Laravel 5.2 ;)

As you like. But if you group them in one branch, you're going to avoid extra work to maintain them.

Laravel 5.1 is LTS version... so for v3, I'm ok to delete the uppercase variable

I added in README.md a list of projects based on this project

@arcanedev-maroc I think now the v3 is ready

Hi @caouecs,

The :Attribute with capital A still in some languages like ca, cs, da ...

After that, i think the v3 is ready to be released ๐Ÿ‘

done

If all is good, this evening ( French hour ), I will merge v3 in master