LaravelDaily/laravel-roles-permissions-manager

CoreUI CDN version has changed, breaking layout

jternent opened this issue · 4 comments

In admin.blade.php there is no specific version assigned to CoreUI. As of this morning, the CDN is pushing 3.0, last night it was 2.1.16. This breaks the navbar in the admin layout.

I've tried adding @2.1.16 to the css and js imports for CoreUI, but that does not work -- I may have not done it right because the direct links below seem to work?

It looks like a lot of classes changed between 2.1.x and 3.0, like navbar is now c-navbar. A full fix would be to find and change all those classes, but a monkeypatch is to download 2.1.16 and change the css and js to local references.

2.1.16 versions:
https://unpkg.com/@coreui/coreui@2.1.16/dist/css/coreui.min.css
https://unpkg.com/@coreui/coreui@2.1.16/dist/js/coreui.min.js

Thanks for the solution.
I downloaded the coreui files to local folders.

This change just broke all the quickadminpanels with CoreUI theme. This is why its not advisable to use CDN for this kind of stuff. Or maybe they should have used a specific version.

Yes we used CDN directly without specifying the version, sorry guys, lesson for us for the future.

Will patch in all repositories and write explanation/instructions article for all quickadminpanel users and customers tomorrow morning Europe time.

Thanks everybody for reporting this issue, fixed now in two commits: 77c9906 7a5f552

Also, published an article on our QuickAdminPanel blog, for our users/customers: For Customers: Replace CoreUI Theme to Use v2.1.16 instead of v3.0

Sorry again!