fi in iterm2 doesn't work

Question

fi in iterm2 doesn't work

dustookk opened this issue 8 years ago · 26 comments

iTerm2 Build 3.0.5
Alfred 3.0.3

fi

[2016-07-20 12:19:58][ERROR: action.applescript] {
NSAppleScriptErrorBriefMessage = "Expected end of line but found class name.";
NSAppleScriptErrorMessage = "Expected end of line but found class name.";
NSAppleScriptErrorNumber = "-2741";
NSAppleScriptErrorRange = "NSRange: {566, 6}";
}

Answer 1 · 2016-07-26T17:26:29.000Z

Thanks for reporting.

Are you using the current workflow version?
If so, when did it stop working?

Answer 2 · 2016-07-27T09:43:27.000Z

yes.
when I press fi, nothing shows up : )

Answer 3 · 2016-07-27T09:55:14.000Z

So you just installed it and it never worked at all?

Answer 4 · 2016-07-29T15:31:16.000Z

It only work with the default terminal. - -|||

Answer 5 · 2016-08-05T08:34:37.000Z

Have you used TerminalFinder before and did it work for you? Or has it never worked for you?

Answer 6 · 2016-08-06T02:29:56.000Z

Hi, I have the same problem and I find the same error messge in console. I haven't used TerminalFinder before. It only work with the default terminal.

Answer 7 · 2016-08-08T19:22:43.000Z

Thanks @mondongxr.

Does running the following script in the script editor work?

tell application "Finder"
  set pathList to (quoted form of POSIX path of (folder of the front window as alias))
  set command to "clear; cd " & pathList
end tell

tell application "System Events"
  -- some versions might identify as "iTerm2" instead of "iTerm"
  set isRunning to (exists (processes where name is "iTerm")) or (exists (processes where name is "iTerm2"))
end tell

tell application "iTerm"
  activate
  set hasNoWindows to ((count of windows) is 0)
  if isRunning and hasNoWindows then
    create window with default profile
  end if
  select first window

  tell the first window
    if isRunning and hasNoWindows is false then
      create tab with default profile
    end if
    tell current session to write text command
  end tell
end tell

Answer 8 · 2016-08-09T08:17:57.000Z

Thank you. I copy your script into Script Editor and run it, but there is the same error.

Answer 9 · 2016-08-09T09:03:00.000Z

Thanks for you support. Can you drill down where exactly (=at which line) the error occurs? I can't reproduce it, so it's a little hard for me.

Answer 10 · 2016-08-10T04:20:09.000Z

Today I find the script works! But I don't know how it works suddenly.
I copy the script into Script Debug and run it. At the first time, it's not ok. In the editor the word 'window' in this line "create window with default profile" is highlighted.
But when I choose debuging and run again. There is on error again and my iTerm opened normally.
Interestingly, the error isn't appeared again however I run the script.
Thank you very much!

Answer 11 · 2016-08-10T06:11:26.000Z

Thanks again. I was afraid that it's this kind of nasty one time error. I have to see if I can drill it down. Right now I don't know how to reproduce, let alone how to fix this.

Will leave this open for ideas and further reports.

Answer 12 · 2016-08-29T19:08:54.000Z

Afraid I have to confirm that this is also happening for me :(

Both the released script and the version you pasted above fail on my end

Steps to reproduce:

Open Alfred Preferences > Workflows > TerminalFinder > fi
Toggle debugging mode and select "Log All Information"
Launch Alfred > type fi

[2016-08-29 20:03:57][input.keyword] Processing output of 'action.applescript' with arg ''
[2016-08-29 20:03:57][ERROR: action.applescript] {
    NSAppleScriptErrorBriefMessage = "Expected end of line but found class name.";
    NSAppleScriptErrorMessage = "Expected end of line but found class name.";
    NSAppleScriptErrorNumber = "-2741";
    NSAppleScriptErrorRange = "NSRange: {513, 6}";
}

Answer 13 · 2016-08-29T19:51:56.000Z

Thx for your report, @oliverturner. I guess you're also a first time user of this workflow and have not used previous versions?

Answer 14 · 2016-09-03T13:35:20.000Z

I was having the same problem with Alfred 2 and iTerm 2 (build 3.0.7).
Fixed it by copying from the raw source for the fi script: https://raw.githubusercontent.com/LeEnno/alfred-terminalfinder/master/src/fi.scpt.txt
Then editing the script in Alfred Workflows, deleting the contents and pasting over the top.
Hope this helps.

Answer 15 · 2016-09-03T15:29:14.000Z

Just checked it, the file in the repo and the script in the workflow diverge by whitespace only. The actual contents are the same.

It may have fixed it for you. Others fixed it by waiting or trying a few times and suddenly it works. So the error is still unknown for now.

Would appreciate any help since I can't reproduce it. Once it works, it seems to always work. I also reinstalled the workflow and still everything works fine.

Answer 16 · 2016-09-17T16:38:16.000Z

I've added the problems all of you mentioned to the readme, maybe this will help narrowing down that sucker of a bug.

Answer 17 · 2016-11-04T15:17:24.000Z

I also met the issue above ,and hunit's suggestion made no sense.My macOS version is 10.12.1,alfred and iTerm2 are update to latest.

Answer 18 · 2016-11-04T16:07:47.000Z

On my Mac, the "fi" workflow information is stored in an info.plist folder in this directory:
~/Library/Application Support/Alfred 2/Alfred.alfredpreferences/workflows/user.workflow.B52348ED-03A8-4521-9D6F-C9E47246E1EC

Here's the settings that are working for me (macOS 10.12.1, Alfred 2 and iTerm 2 (build 3.0.7):

In the info.plist, under objects -> Item 6 -> config ...
argumenttype Number 2
keyword String fi
subtext String Open current Finder directory in iTerm
text String Finder → iTerm
withspace Boolean NO
type String alfred.workflow.input.keyword
uid String AA3CDA14-C3B5-442B-B117-D61A244C6625
version Number 0

It might be worth checking file permissions, time/date on this file, and the above settings ?
Manually copying and pasting in the workflow script (as in a previous suggestion), "touched" the date/time of this file, but I can't see why else it suddenly started working for me.

Hope this helps.

Answer 19 · 2016-11-07T07:55:20.000Z

hello,
when i run #if command, show error:
The application /System/Library/CoreServices/Finder.app cannot be opened because its executable is missing.

Answer 20 · 2016-11-07T10:44:23.000Z

@huntit thx for the hint. I will have a look.

@g63336180 would you mind opening a separate issue to keep concerns separated?

Answer 21 · 2017-06-15T17:55:42.000Z

This is working what's working for me:

pi:

tell application "Path Finder"
	set pathList to POSIX path of the target of the front finder window
	set command to "clear; cd " & pathList
end tell

tell application "System Events"
	set isRunning to (exists (processes where name is "iTerm3	"))
end tell

tell application "iTerm"
	activate
	set hasNoWindows to ((count of windows) is 0)
	if isRunning and hasNoWindows then
		create window with default profile
	end if
	select first window
	
	tell the first window
		if isRunning and hasNoWindows is false then
			create tab with default profile
		end if
		tell current session to write text command
	end tell
end tell

ip:

on alfred_script(q)
	tell application "iTerm"
	  tell the current session of current tab of current window
		write text "open -a 'Path Finder' ./"
	end tell
  end tell

end alfred_script

Hope that helps someone. I don't use the other commands so I can attest to those.

Answer 22 · 2018-04-12T16:29:22.000Z

It works for me ,
i just change "iTerm" to "iTerm2"

fi

on alfred_script(q)
  
  tell application "Finder"
    set pathList to (quoted form of POSIX path of (folder of the front window as alias))
    set command to "clear; cd " & pathList
  end tell
  
  tell application "System Events"
    -- some versions might identify as "iTerm2" instead of "iTerm"
    set isRunning to (exists (processes where name is "iTerm")) or (exists (processes where name is "iTerm2"))
  end tell
  
  tell application "iTerm2"
    activate
    set hasNoWindows to ((count of windows) is 0)
    if isRunning and hasNoWindows then
      create window with default profile
    end if
    select first window
    
    tell the first window
      if isRunning and hasNoWindows is false then
        create tab with default profile
      end if
      tell current session to write text command
    end tell
  end tell
  
end alfred_script

if

on alfred_script(q)
  tell application "iTerm2"
    tell the current session of current window
      write text "open -a Finder ./"
    end tell
  end tell
end alfred_script

Answer 23 · 2018-04-12T16:32:47.000Z

Yosemite 10.10.5

Answer 24 · 2018-10-16T13:28:53.000Z

when i run fi, display in debug log:
[ERROR: action.applescript] {
NSAppleScriptErrorAppName = Finder;
NSAppleScriptErrorBriefMessage = "Not authorized to send Apple events to Finder.";
NSAppleScriptErrorMessage = "Not authorized to send Apple events to Finder.";
NSAppleScriptErrorNumber = "-1743";

Answer 25 · 2018-11-21T16:54:16.000Z

Ok so i have a solution that is not 💯but flipping good enough. I change the AppleScript in the fi command to this:

on alfred_script(q)
	tell application "Finder"
		set pathList to (quoted form of POSIX path of (folder of the front window as alias))
	end tell
	
	tell application "System Events"
        do shell script "open -a iTerm " & pathList
	end tell
end alfred_script

All this does is let OSX do the heavy lifting. sure this looses options like using the current window or tab but it gets my an iterm on my finder directory and i can deal with all the other stuff.

Answer 26 · 2023-06-12T20:10:34.000Z

@infn8 I totally slept on this, I'm sorry. I took that idea after a comment in #23 and went with it. This should solve this issue since the apple script doesn't mention iTerm at all. Long time coming 😇