Leafpub/leafpub

Caption box on images prevents centre justify

trentyarwood opened this issue · 4 comments

trentyarwood commented

Issue Summary

Images can be centre justified in the image sidebar or in the editor.

Opening the sidebar, clicking the "add a caption" checkbox left-justifies the picture, prevents centre justification of the image in the editor.

Steps to Reproduce

Add image.
Click "Centre Justify"
Click image properties button
Select "add a caption"
Click Submit
Attempt to re-centre-justify picture in editor.

Additional info

  • Leafpub version: 1.2b1
  • PHP version: 7.0.15
  • Affected browsers: Chrome
  • Operating system: Host: Ubuntu 16.04; view: Win 10

See: The xkcd in this post: https://postleaf.yarwood.id.au/concern-trolling-101

karsasmus commented

Hi @trentyarwood ,

this bug has been fixed with the latest release of Range (https://github.com/Leafpub/range/blob/master/css/theme.css#L694)

The latest beta of Leafpub ( beta4 ) includes Range 1.1.0 🙂

trentyarwood commented

Ahah. I customised range with a new font and a couple of minor changes, so haven't been updating the themes. Cheers.

trentyarwood commented

Still doing this with new range and b4:

Before caption box:
temp1

After caption box:

temp2

karsasmus commented

Hi @trentyarwood ,

you're right, sorry for that. I've fixed the bug on master.
A workaround until the next beta will be released:

  • Remove caption
  • Remove img alignment
  • submit
  • reopen dialog
  • Add caption and alignment
  • submit

Your pic with caption should be aligned left now.